Verification report

• generate Embedded ObjectMeta in the CRDs with new update-crdgen.sh
• kubectl apply -f operator/config/crds/operator.karmada.io_karmadas.yaml

➜  karmada git:(master) ✗ kubectl apply -f operator/config/crds/operator.karmada.io_karmadas.yaml 
customresourcedefinition.apiextensions.k8s.io/karmadas.operator.karmada.io configured

• kubectl apply -f operator/config/samples/karmada.yaml

➜  karmada git:(master) ✗ kubectl apply -f operator/config/samples/karmada.yaml 
karmada.operator.karmada.io/karmada-demo configured

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf1dbf0) 51.99% compared to head (798f916) 51.89%.
Report is 105 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #4315      +/-   ##
==========================================
- Coverage   51.99%   51.89%   -0.11%     
==========================================
  Files         242      243       +1     
  Lines       23977    24150     +173     
==========================================
+ Hits        12468    12532      +64     
- Misses      10829    10935     +106     
- Partials      680      683       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

/assign

Can you help test the situation where both namespace and name are numbers? For example, name = 123, namespace=123. @zhzhuang-zju

Can you help test the situation where both namespace and name are numbers? For example, name = 123, namespace=123. @zhzhuang-zju

Do you mean namepace and name of the embedded objectMeta?

Can you help test the situation where both namespace and name are numbers? For example, name = 123, namespace=123. @zhzhuang-zju

I tested it according to your request and the results are as follows.

1. set both namespace and name to 123, and it failed for invalid value.

➜  karmada git:(master) ✗ kubectl apply -f operator/config/samples/karmada.yaml 
The Karmada "karmada-demo" is invalid: 
* spec.components.etcd.local.volumeData.volumeClaim.metadata.namespace: Invalid value: "integer": spec.components.etcd.local.volumeData.volumeClaim.metadata.namespace in body must be of type string: "integer"
* spec.components.etcd.local.volumeData.volumeClaim.metadata.name: Invalid value: "integer": spec.components.etcd.local.volumeData.volumeClaim.metadata.name in body must be of type string: "integer"

2. set both namespace and name to "123", and it succeed

➜  karmada git:(master) ✗ kubectl apply -f operator/config/samples/karmada.yaml
karmada.operator.karmada.io/karmada-demo created

cc @chaunceyjiang

set both namespace and name to 123, and it failed for invalid value.

This is exactly the issue I encountered. It seems that your PR did not solve this issue, right?

set both namespace and name to 123, and it failed for invalid value.

This is exactly the issue I encountered. It seems that your PR did not solve this issue, right?

Do you mean that you want to set name or namespace a int value?

set both namespace and name to 123, and it failed for invalid value.

This is exactly the issue I encountered. It seems that your PR did not solve this issue, right?

@chaunceyjiang Hi~ referring to your issue #4332, what you expect is to set the namespace and name to "123", if so, this PR solves the problem, you can refer to #4315 (comment) for the second scenario.

@chaunceyjiang Would you like to take another look?

/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here